Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Throw explicit transaction has been marked for rollback only exception #4971

Merged
merged 3 commits into from
Apr 2, 2024
Merged

BUGFIX: Throw explicit transaction has been marked for rollback only exception #4971

merged 3 commits into from
Apr 2, 2024

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Apr 1, 2024 •
edited
Loading

related #4970

improves the error message from totally obscured:

Failed to update and commit highest applied sequence number for subscriber "Neos\ContentGraph\DoctrineDbalAdapter\DoctrineDbalContentGraphProjection". Please run Neos\ContentRepository\Core\Infrastructure\DbalCheckpointStorage::setUp()

to partially obscure:

Failed to update and commit checkpoint for subscriber "Neos\ContentGraph\DoctrineDbalAdapter\DoctrineDbalContentGraphProjection" because the transaction has been marked for rollback only. See #4970

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign mentioned this pull request Apr 1, 2024
Closed
@mhsdesign mhsdesign marked this pull request as ready for review April 2, 2024 13:30
@mhsdesign mhsdesign changed the title BUGFIX: Deobscurify projection errors BUGFIX: Throw explicit transaction has been marked for rollback only exception Apr 2, 2024
@mhsdesign
Copy link
Member Author

I will not attempt to fix #4970 actually in this pr. The current state and dx will already be improved with this hint.

dlubitz
dlubitz approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhsdesign
Copy link
Member Author

Will merge this as this is a tiny debug developer improvement (no production behaviour change) and should not block our review capacity, which is currently low

@mhsdesign mhsdesign merged commit 1ee0ef6 into neos:9.0 Apr 2, 2024
10 checks passed
@bwaidelich
Copy link
Member

btw: since each apply() call is wrapped in a transaction anyways (for the checkpoint storage) I think we can remove all these nested transactions within.
I'll take care of that when working on the syncronous catchup implementation

@mhsdesign mhsdesign deleted the bugfix/deobscurifyProjectionErrors branch April 5, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@nezaniel nezaniel Awaiting requested review from nezaniel

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsdesign @bwaidelich @dlubitz